Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable current workflows for builder #4287

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Disable current workflows for builder #4287

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec29506
Disable current workflows for builder
jpkrohling Oct 28, 2021
34d377d
Re-enable codeql for builder
jpkrohling Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Disable current workflows for builder 
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
  • Loading branch information
@jpkrohling
jpkrohling committed Oct 28, 2021
commit ec29506ecd109361054740f672d2d82aa8f3dedd
2 changes: 2 additions & 0 deletions .github/workflows/api-compatibility.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
name: "Inform Incompatible PRs"
on:
pull_request:
paths-ignore:
- 'builder/**'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the other PR, I would prefer cmd/builder since it is a command :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the first step of a multi-step move. The other PR is mostly the whole repo of builder with its history, all places in one directory. If you prefer the whole application to be within cmd/builder, that's doable, but if you mean just the main.go for the application, then I will tackle that in subsequent PRs.

branches:
- main

Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/build-and-test-windows.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ name: build-and-test-windows
on:
push:
branches: [ main ]
paths-ignore:
- 'builder/**'
tags:
- 'v[0-9]+.[0-9]+.[0-9]+*'
pull_request:
paths-ignore:
- 'builder/**'

jobs:
windows-unittest:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ name: build-and-test
on:
push:
branches: [main]
paths-ignore:
- 'builder/**'
tags:
- "v[0-9]+.[0-9]+.[0-9]+*"
pull_request:
paths-ignore:
- 'builder/**'

jobs:
setup-environment:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/check-links.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ name: check-links
on:
push:
branches: [ main ]
paths-ignore:
- 'builder/**'
pull_request:
paths-ignore:
- 'builder/**'
Comment on lines +5 to +9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

links check is ok to run for the builder as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are currently failing with the link checks for the release instructions, as I reference a non-existing tag as example. I have a first ready for this, to be sent on a third PR.


jobs:
check-links:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,11 @@ name: "CodeQL Analysis"
on:
push:
branches: [ main ]
paths-ignore:
- 'builder/**'
pull_request:
paths-ignore:
- 'builder/**'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codeql should run all the time even for builder.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, and I think this might already work out of the box. If it doesn't after merging this, I'll open another PR disabling CodeQL temporarily.


jobs:
CodeQL-Build:
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/contrib-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,13 @@ name: contrib-tests
on:
push:
branches: [ main ]
paths-ignore:
- 'builder/**'
tags:
- v[0-9]+.[0-9]+.[0-9]+.*
pull_request:
paths-ignore:
- 'builder/**'

jobs:
contrib_tests:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ name: Dependabot-Tidier
on:
pull_request:
types: [ labeled ]
paths-ignore:
- 'builder/**'
Comment on lines +6 to +7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not ignore this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the tidier, shouldn't be critical for this first step. Or is it?


jobs:
mod_tidier:
Expand Down