Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set grpc logger to collector #4501

Merged
merged 11 commits into from
Dec 13, 2021
Merged

Set grpc logger to collector #4501

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8b2c69c
Set grpc logger to collector
pavankrish123 Nov 30, 2021
5bbcd41
added commit message
pavankrish123 Dec 1, 2021
9b0cf8b
added comment
pavankrish123 Dec 2, 2021
4e19b87
added comment
pavankrish123 Dec 2, 2021
bb15c20
removed temorary file
pavankrish123 Dec 2, 2021
9210d3e
removed usage of settable from grpc middleware and work around
pavankrish123 Dec 3, 2021
c44808e
fixed comments
pavankrish123 Dec 3, 2021
542b4c9
fixed comments
pavankrish123 Dec 3, 2021
8199c1d
fixed comments
pavankrish123 Dec 3, 2021
7e625e1
Merge branch 'main' into new/grpclogging
pavankrish123 Dec 3, 2021
c2f49c0
added comment explaining ignore error
pavankrish123 Dec 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed comments
  • Loading branch information
@pavankrish123
pavankrish123 committed Dec 3, 2021
commit 8199c1dedc081d1f9c62f84e9ebd72160785a5e6
1 change: 0 additions & 1 deletion service/collector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@ func (col *Collector) setupConfigurationComponents(ctx context.Context) error {
return fmt.Errorf("failed to get logger: %w", err)
}

// must be called once - that too before any GRPC calls.
telemetrylogs.NewColGRPCLogger(col.logger, col.cfgW.cfg.Service.Telemetry.Logs.Level).SetGRPCLogger()

col.logger.Info("Applying configuration...")
Expand Down