Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BoundedMemoryQueue to consume remaining items on close #5203

Merged
merged 7 commits into from
Apr 14, 2022
Merged

Update BoundedMemoryQueue to consume remaining items on close #5203

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f826e0a
BoundedMemoryQueue now consumes on close
TylerHelmuth Apr 13, 2022
ba50e47
Merge remote-tracking branch 'origin/main' into issue-5110
TylerHelmuth Apr 13, 2022
a075591
Add back !ok return
TylerHelmuth Apr 13, 2022
7fe8d9b
Removed stopCh
TylerHelmuth Apr 14, 2022
fd879ea
Merge branch 'main' into issue-5110
TylerHelmuth Apr 14, 2022
a3bb83e
Cleanup
TylerHelmuth Apr 14, 2022
7ba3428
Updated CHANGELOG.md
TylerHelmuth Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
  • Loading branch information
@TylerHelmuth
TylerHelmuth committed Apr 14, 2022
commit a3bb83e49def368a3e921d108926a7abf020f3fd
1 change: 0 additions & 1 deletion exporter/exporterhelper/internal/bounded_memory_queue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ func (q *boundedMemoryQueue) StartConsumers(numWorkers int, callback func(item i
q.size.Sub(1)
itemConsumer.consume(item)
}
return
}()
}
startWG.Wait()
Expand Down
1 change: 0 additions & 1 deletion exporter/exporterhelper/internal/bounded_memory_queue_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ func TestShutdownWhileNotEmpty(t *testing.T) {

q.StartConsumers(1, func(item interface{}) {
consumerState.record(item.(string))
//
time.Sleep(1 * time.Second)
})

Expand Down