Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Delete pdata func from (v0.47.0) #5307

Merged
merged 1 commit into from
May 3, 2022
Merged

Remove deprecated Delete pdata func from (v0.47.0) #5307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove deprecated Delete pdata func from (v0.47.0)
  • Loading branch information
Alex Boten committed May 3, 2022
commit 90fcb1ec05199ea68d0f736a4c949e1c413ff828
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
- Remove pdata deprecated funcs from 2 versions (v0.48.0) ago. (#5219)
- Remove non pdata deprecated funcs/structs (#5220)
- `pmetric.Exemplar.ValueType()` now returns new type `ExemplarValueType` (#5233)
- Remove deprecated `Delete` pdata func from (v0.47.0). (#5307)

### 🚩 Deprecations 🚩

Expand Down
5 changes: 0 additions & 5 deletions pdata/internal/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,11 +619,6 @@ func (m Map) Get(key string) (Value, bool) {
return Value{nil}, false
}

// Deprecated: [v0.47.0] Use Remove instead.
func (m Map) Delete(key string) bool {
return m.Remove(key)
}

// Remove removes the entry associated with the key and returns true if the key
// was present in the map, otherwise returns false.
func (m Map) Remove(key string) bool {
Expand Down