Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ToClientWithHost to ToClient #5737

Merged
merged 5 commits into from
Jul 26, 2022

Conversation

fatsheep9146
Copy link
Contributor

Signed-off-by: Ziqi Zhao [email protected]

Fix #5061

@fatsheep9146 fatsheep9146 requested review from a team and codeboten July 23, 2022 16:01
@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #5737 (2242f31) into main (e6b5e25) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #5737      +/-   ##
==========================================
- Coverage   91.57%   91.56%   -0.02%     
==========================================
  Files         192      192              
  Lines       11425    11426       +1     
==========================================
- Hits        10463    10462       -1     
- Misses        768      770       +2     
  Partials      194      194              
Impacted Files Coverage Δ
config/confighttp/confighttp.go 98.74% <66.66%> (-1.26%) ⬇️
exporter/otlphttpexporter/otlp.go 83.84% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6b5e25...2242f31. Read the comment docs.

@fatsheep9146
Copy link
Contributor Author

Error: exporter/prometheusremotewriteexporter/exporter.go:99:50: cannot use host.GetExtensions() (value of type map[config.ComponentID]component.Extension) as type component.Host in argument to prwe.clientSettings.ToClient:

How can I handle these compile fail for other exporters due to this breaking changes? Should I directly submit prs for these exporters to opentelemetry-collector-contrib project?

@mx-psi @codeboten

CHANGELOG.md Outdated Show resolved Hide resolved
config/confighttp/confighttp.go Show resolved Hide resolved
fatsheep9146 and others added 5 commits July 27, 2022 07:35
Signed-off-by: Ziqi Zhao <[email protected]>
Signed-off-by: Ziqi Zhao <[email protected]>
Co-authored-by: Pablo Baeyens <[email protected]>
Signed-off-by: Ziqi Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTPClientSettings.ToClient is inconsistent with other To* config methods
3 participants