Skip to content

Conversation

@MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Dec 3, 2025

Identified in the review of #7648

@MrAlias MrAlias added this to the v1.39.0 milestone Dec 3, 2025
@MrAlias MrAlias added documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry labels Dec 3, 2025
@MrAlias MrAlias marked this pull request as ready for review December 3, 2025 20:50
Copilot AI review requested due to automatic review settings December 3, 2025 20:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes documentation issues in the semconv/v1.33.0 package by correcting package name documentation and adding missing copyright headers to 20 metric.go files across various semantic convention subdirectories (vcsconv, systemconv, signalrconv, rpcconv, processconv, otelconv, messagingconv, k8sconv, hwconv, httpconv, goconv, genaiconv, faasconv, dnsconv, dbconv, cpuconv, containerconv, cicdconv, azureconv).

Key changes:

  • Adds missing copyright headers (Copyright The OpenTelemetry Authors and SPDX-License-Identifier: Apache-2.0) after the "Code generated" comment
  • Corrects package documentation that incorrectly referenced "httpconv" to the actual package name (e.g., "vcsconv", "systemconv", etc.)

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
semconv/v1.33.0/vcsconv/metric.go Adds copyright header and corrects package name from "httpconv" to "vcsconv"
semconv/v1.33.0/systemconv/metric.go Adds copyright header and corrects package name from "httpconv" to "systemconv"
semconv/v1.33.0/signalrconv/metric.go Adds copyright header and corrects package name from "httpconv" to "signalrconv"
semconv/v1.33.0/rpcconv/metric.go Adds copyright header and corrects package name from "httpconv" to "rpcconv"
semconv/v1.33.0/processconv/metric.go Adds copyright header and corrects package name from "httpconv" to "processconv"
semconv/v1.33.0/otelconv/metric.go Adds copyright header and corrects package name from "httpconv" to "otelconv"
semconv/v1.33.0/messagingconv/metric.go Adds copyright header and corrects package name from "httpconv" to "messagingconv"
semconv/v1.33.0/k8sconv/metric.go Adds copyright header and corrects package name from "httpconv" to "k8sconv"
semconv/v1.33.0/hwconv/metric.go Adds copyright header and corrects package name from "httpconv" to "hwconv"
semconv/v1.33.0/httpconv/metric.go Adds copyright header (package name already correct)
semconv/v1.33.0/goconv/metric.go Adds copyright header and corrects package name from "httpconv" to "goconv"
semconv/v1.33.0/genaiconv/metric.go Adds copyright header and corrects package name from "httpconv" to "genaiconv"
semconv/v1.33.0/faasconv/metric.go Adds copyright header and corrects package name from "httpconv" to "faasconv"
semconv/v1.33.0/dnsconv/metric.go Adds copyright header and corrects package name from "httpconv" to "dnsconv"
semconv/v1.33.0/dbconv/metric.go Adds copyright header and corrects package name from "httpconv" to "dbconv"
semconv/v1.33.0/cpuconv/metric.go Adds copyright header and corrects package name from "httpconv" to "cpuconv"
semconv/v1.33.0/containerconv/metric.go Adds copyright header and corrects package name from "httpconv" to "containerconv"
semconv/v1.33.0/cicdconv/metric.go Adds copyright header and corrects package name from "httpconv" to "cicdconv"
semconv/v1.33.0/azureconv/metric.go Adds copyright header and corrects package name from "httpconv" to "azureconv"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.1%. Comparing base (e69beb8) to head (9074c41).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7658     +/-   ##
=======================================
- Coverage   86.1%   86.1%   -0.1%     
=======================================
  Files        298     298             
  Lines      21709   21709             
=======================================
- Hits       18708   18704      -4     
- Misses      2624    2628      +4     
  Partials     377     377             

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrAlias MrAlias merged commit 3659648 into open-telemetry:main Dec 5, 2025
29 of 30 checks passed
@MrAlias MrAlias deleted the fix-semconv-v1.33.0 branch December 5, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants