-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix package name documentation and missing copyright in semconv/v1.33.0
#7658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes documentation issues in the semconv/v1.33.0 package by correcting package name documentation and adding missing copyright headers to 20 metric.go files across various semantic convention subdirectories (vcsconv, systemconv, signalrconv, rpcconv, processconv, otelconv, messagingconv, k8sconv, hwconv, httpconv, goconv, genaiconv, faasconv, dnsconv, dbconv, cpuconv, containerconv, cicdconv, azureconv).
Key changes:
- Adds missing copyright headers (
Copyright The OpenTelemetry AuthorsandSPDX-License-Identifier: Apache-2.0) after the "Code generated" comment - Corrects package documentation that incorrectly referenced "httpconv" to the actual package name (e.g., "vcsconv", "systemconv", etc.)
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| semconv/v1.33.0/vcsconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "vcsconv" |
| semconv/v1.33.0/systemconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "systemconv" |
| semconv/v1.33.0/signalrconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "signalrconv" |
| semconv/v1.33.0/rpcconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "rpcconv" |
| semconv/v1.33.0/processconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "processconv" |
| semconv/v1.33.0/otelconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "otelconv" |
| semconv/v1.33.0/messagingconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "messagingconv" |
| semconv/v1.33.0/k8sconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "k8sconv" |
| semconv/v1.33.0/hwconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "hwconv" |
| semconv/v1.33.0/httpconv/metric.go | Adds copyright header (package name already correct) |
| semconv/v1.33.0/goconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "goconv" |
| semconv/v1.33.0/genaiconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "genaiconv" |
| semconv/v1.33.0/faasconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "faasconv" |
| semconv/v1.33.0/dnsconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "dnsconv" |
| semconv/v1.33.0/dbconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "dbconv" |
| semconv/v1.33.0/cpuconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "cpuconv" |
| semconv/v1.33.0/containerconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "containerconv" |
| semconv/v1.33.0/cicdconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "cicdconv" |
| semconv/v1.33.0/azureconv/metric.go | Adds copyright header and corrects package name from "httpconv" to "azureconv" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7658 +/- ##
=======================================
- Coverage 86.1% 86.1% -0.1%
=======================================
Files 298 298
Lines 21709 21709
=======================================
- Hits 18708 18704 -4
- Misses 2624 2628 +4
Partials 377 377 🚀 New features to boost your workflow:
|
Identified in the review of #7648