Skip to content

docs: add UnitedDeployment v1beta1 promotion proposal#2392

Open
Kunal1522 wants to merge 1 commit intoopenkruise:masterfrom
Kunal1522:ud-v1beta1-proposal
Open

docs: add UnitedDeployment v1beta1 promotion proposal#2392
Kunal1522 wants to merge 1 commit intoopenkruise:masterfrom
Kunal1522:ud-v1beta1-proposal

Conversation

@Kunal1522
Copy link
Contributor

@Kunal1522 Kunal1522 commented Mar 23, 2026

Summary

  • add a proposal for UnitedDeployment v1beta1 promotion
  • focus on API contract, validation/defaulting, rollout semantics, and promotion plumbing
  • include review questions for the remaining beta decisions

Copilot AI review requested due to automatic review settings March 23, 2026 23:41
@kruise-bot kruise-bot requested review from Fei-Guo and zmberg March 23, 2026 23:41
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fei-guo for approval by writing /assign @fei-guo in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Kunal1522 <kunalkashyap8024@gmail.com>
@Kunal1522 Kunal1522 force-pushed the ud-v1beta1-proposal branch from 2a7af8f to 3143f4e Compare March 23, 2026 23:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a design/proposal document to guide promoting UnitedDeployment from v1alpha1 to v1beta1, focusing on API contract clarifications and cleanup items needed prior to serving the beta API.

Changes:

  • Introduces a promotion proposal covering API surface gaps (e.g., subsets[].patch contract, status field ownership).
  • Documents validation/defaulting inconsistencies and rollout/revision semantics that need resolution before v1beta1.
  • Lists concrete promotion plumbing steps (new v1beta1 types, conversions, CRD serving changes, tests, and migration notes) plus review questions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +27 to +34
- [`uniteddeployment_types.go:220-226`](../../apis/apps/v1alpha1/uniteddeployment_types.go)

But the adapters apply it to `spec.template` only:

- [`statefulset_adapter.go:170-184`](../../pkg/controller/uniteddeployment/adapter/statefulset_adapter.go)
- [`advanced_statefulset_adapter.go:184-199`](../../pkg/controller/uniteddeployment/adapter/advanced_statefulset_adapter.go)
- [`cloneset_adapter.go:149-163`](../../pkg/controller/uniteddeployment/adapter/cloneset_adapter.go)
- [`deployment_adapter.go:164-179`](../../pkg/controller/uniteddeployment/adapter/deployment_adapter.go)
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several references include specific line ranges in the link text (e.g., uniteddeployment_types.go:220-226), but the Markdown link target points only to the file path without a #Lx-Ly anchor. This makes the line-range references non-clickable/misleading; consider adding GitHub line anchors (or removing the line-range from the visible text) consistently throughout the doc.

Suggested change
- [`uniteddeployment_types.go:220-226`](../../apis/apps/v1alpha1/uniteddeployment_types.go)
But the adapters apply it to `spec.template` only:
- [`statefulset_adapter.go:170-184`](../../pkg/controller/uniteddeployment/adapter/statefulset_adapter.go)
- [`advanced_statefulset_adapter.go:184-199`](../../pkg/controller/uniteddeployment/adapter/advanced_statefulset_adapter.go)
- [`cloneset_adapter.go:149-163`](../../pkg/controller/uniteddeployment/adapter/cloneset_adapter.go)
- [`deployment_adapter.go:164-179`](../../pkg/controller/uniteddeployment/adapter/deployment_adapter.go)
- [`uniteddeployment_types.go:220-226`](../../apis/apps/v1alpha1/uniteddeployment_types.go#L220-L226)
But the adapters apply it to `spec.template` only:
- [`statefulset_adapter.go:170-184`](../../pkg/controller/uniteddeployment/adapter/statefulset_adapter.go#L170-L184)
- [`advanced_statefulset_adapter.go:184-199`](../../pkg/controller/uniteddeployment/adapter/advanced_statefulset_adapter.go#L184-L199)
- [`cloneset_adapter.go:149-163`](../../pkg/controller/uniteddeployment/adapter/cloneset_adapter.go#L149-L163)
- [`deployment_adapter.go:164-179`](../../pkg/controller/uniteddeployment/adapter/deployment_adapter.go#L164-L179)

Copilot uses AI. Check for mistakes.
@codecov
Copy link

codecov bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.77%. Comparing base (530f9c9) to head (3143f4e).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2392      +/-   ##
==========================================
+ Coverage   48.68%   48.77%   +0.09%     
==========================================
  Files         324      324              
  Lines       27920    27928       +8     
==========================================
+ Hits        13592    13623      +31     
+ Misses      12787    12775      -12     
+ Partials     1541     1530      -11     
Flag Coverage Δ
unittests 48.77% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L size/L: 100-499

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants