Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Opaque Integer Resources #19592

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

mburke5678
Copy link
Contributor

Per #19347

I see that Opaque Integer Resources are removed from 1.9 version as per the link here kubernetes/enhancements#76 (comment) so documentation related to Opaque Integer Resources should be removed.

Verified by @rphillips in Slack: https://coreos.slack.com/archives/CK1AE4ZCK/p1581020513181400

@openshift-docs-preview-bot

@mburke5678
Copy link
Contributor Author

@sunilcio Is this a PR you can review?

@mburke5678
Copy link
Contributor Author

Files removed from 3.x via #19593

@vikram-redhat
Copy link
Contributor

Anytime we remove or change a previously documented (and supported) feature we need to follow the steps outlined recently to help support these changes and help make the transition.

We need acks from Product Experience, Docs, PM, Eng and QE. We also need to send out information about this change to openshift-sme and aos-devel, before we make this change, and once the change is done.

@sferich888 and/or @reestr do you ack this change from both 3.11 and 4.x docs?
@xltian is this ok from QE?

@mburke5678 - Since eng raised this issue, happy to consider this as an ack. Not sure which PM can ack this change though. Can you confirm with eng?

@sferich888
Copy link
Contributor

Based on kubernetes/enhancements#76 (comment) removing this from 3.10 and 3.11 docs should be OK, given that upstream kube dropped support for this resource in 1.9 (3.9)

@vikram-redhat
Copy link
Contributor

@tkatarki are you ok with us removing this from the docs for both 3.x and 4.x?

@xltian
Copy link

xltian commented Feb 7, 2020

@sunilcio Can you please review from QE? Thanks

@jhou1
Copy link
Member

jhou1 commented Feb 7, 2020

@weinliu PTAL

@weinliu
Copy link

weinliu commented Feb 7, 2020

Anytime we remove or change a previously documented (and supported) feature we need to follow the steps outlined recently to help support these changes and help make the transition.

We need acks from Product Experience, Docs, PM, Eng and QE. We also need to send out information about this change to openshift-sme and aos-devel, before we make this change, and once the change is done.

@sferich888 and/or @reestr do you ack this change from both 3.11 and 4.x docs?
@xltian is this ok from QE?

@mburke5678 - Since eng raised this issue, happy to consider this as an ack. Not sure which PM can ack this change though. Can you confirm with eng?

Removing this is ok for QE as per:

Removed opaque integer resources (deprecated in v1.8) #55103
kubernetes/kubernetes#55103

@mburke5678
Copy link
Contributor Author

mburke5678 commented Feb 7, 2020

@rphillips do you ack this change from both 3.11 and 4.x docs?

@mburke5678
Copy link
Contributor Author

@tkatarki @rphillips do you ack this change from both 3.11 and 4.x docs?

@mburke5678
Copy link
Contributor Author

@tkatarki Approved via Slack.

@rphillips
Copy link
Contributor

/lgtm
Thanks!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2020
@mburke5678 mburke5678 merged commit 02d53c6 into openshift:master Mar 9, 2020
@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.1

@openshift-cherrypick-robot

@mburke5678: new pull request created: #20344

In response to this:

/cherrypick enterprise-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.2

@openshift-cherrypick-robot

@mburke5678: new pull request created: #20345

In response to this:

/cherrypick enterprise-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.3

@openshift-cherrypick-robot

@mburke5678: new pull request created: #20346

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678
Copy link
Contributor Author

/cherrypick enterprise-4.4

@openshift-cherrypick-robot

@mburke5678: new pull request created: #20347

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mburke5678 mburke5678 deleted the nodes-remove-opaque branch July 23, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.1 branch/enterprise-4.2 branch/enterprise-4.3 branch/enterprise-4.4 lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants