PR #18152: [XLA:GPU] Avoid fusion-wrapping copies #18192
+39
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imported from GitHub PR #18152 Fusion wrapping copies breaks the logic for detecting copies from copy-insertion in rematerialization pass. This patch avoids wrapping copy instructions and instead emits them directly in IrEmitterUnnested. This should fix #17922 Copybara import of the project: -- 49daad1 by Jaroslav Sevcik <[email protected]>: Avoid fusion-wrapping copies Merging this change closes #18152 FUTURE_COPYBARA_INTEGRATE_REVIEW=#18152 from jaro-sevcik:avoid-fusion-wrapping-copies 49daad1 PiperOrigin-RevId: 684709374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #18152: [XLA:GPU] Avoid fusion-wrapping copies
Imported from GitHub PR #18152
Fusion wrapping copies breaks the logic for detecting copies from copy-insertion in rematerialization pass.
This patch avoids wrapping copy instructions and instead emits them directly in IrEmitterUnnested.
This should fix #17922
Copybara import of the project:
--
49daad1 by Jaroslav Sevcik [email protected]:
Avoid fusion-wrapping copies
Merging this change closes #18152
FUTURE_COPYBARA_INTEGRATE_REVIEW=#18152 from jaro-sevcik:avoid-fusion-wrapping-copies 49daad1