Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XLA:GPU] Plumb through AppendPipelinedInstruction. #19106

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

copybara-service[bot]
Copy link

[XLA:GPU] Plumb through AppendPipelinedInstruction.

This enables annotations of pipelined instructions (implemented in previous diffs) in the GPU pipeline.

In addition:

  1. It does a small non functional rewrite of AppendPipelinedInstruction to return status directly and properly dereference StatusOr.
  2. Makes sure we preserve backend config when creating async collectives.
  3. Adds a relevant automated unit test which runs the entire high level GPU compilation pipeline and checks whether there is a pipelined annotation.

This enables annotations of pipelined instructions (implemented in previous diffs) in the GPU pipeline.

In addition:

1. It does a small non functional rewrite of AppendPipelinedInstruction to return status directly and properly dereference StatusOr.
2. Makes sure we preserve backend config when creating async collectives.
3. Adds a relevant automated unit test which runs the entire high level GPU compilation pipeline and checks whether there is a pipelined annotation.

PiperOrigin-RevId: 697934943
@copybara-service copybara-service bot merged commit 38dbb44 into main Nov 19, 2024
1 check passed
@copybara-service copybara-service bot deleted the test_693687788 branch November 19, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant