[tsl:concurrency] Add CountDownAsyncValueRef to concurrency library #19403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd2d502 to
b02e4eb
Compare
This idiom is used in a few places in XLA:CPU executor, and TPU runtime. Conceptually it's similar to https://en.cppreference.com/w/cpp/thread/latch, but for async values. BM_CountDownSuccess/4 31.4 ns 31.4 ns 19308520 BM_CountDownSuccess/8 37.1 ns 37.0 ns 18911191 BM_CountDownSuccess/16 57.3 ns 57.3 ns 12371255 BM_CountDownSuccess/32 90.1 ns 90.0 ns 7746279 BM_CountDownError/4 75.8 ns 75.8 ns 8899579 BM_CountDownError/8 110 ns 110 ns 6349328 BM_CountDownError/16 171 ns 171 ns 4068219 BM_CountDownError/32 290 ns 290 ns 2402659 PiperOrigin-RevId: 697760432
b02e4eb to
3844060
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[tsl:concurrency] Add CountDownAsyncValueRef to concurrency library
This idiom is used in a few places in XLA:CPU executor, and TPU runtime.
Conceptually it's similar to https://en.cppreference.com/w/cpp/thread/latch, but for async values.
BM_CountDownSuccess/4 31.4 ns 31.4 ns 19308520
BM_CountDownSuccess/8 37.1 ns 37.0 ns 18911191
BM_CountDownSuccess/16 57.3 ns 57.3 ns 12371255
BM_CountDownSuccess/32 90.1 ns 90.0 ns 7746279
BM_CountDownError/4 75.8 ns 75.8 ns 8899579
BM_CountDownError/8 110 ns 110 ns 6349328
BM_CountDownError/16 171 ns 171 ns 4068219
BM_CountDownError/32 290 ns 290 ns 2402659