Remove :cuda_runtime and :rocm_runtime targets #19541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
282d089 to
4206e23
Compare
4206e23 to
893c710
Compare
- The remaining `GetRuntimeVersion` and `GetFuncBySymbol` functions get moved into the executors - the only place where they are needed. - For CUDA is also create an overload of `cuda::ToStatus` which can convert a CUDA runtime error (`cudaError_t`) into an `absl::Status`. - I also had to adjust the `RocmKernel` and `CudaKernel` tests which were using `GetFuncBySymbol` directly. Now they rely on `LoadKernel` from the executors. PiperOrigin-RevId: 698720699
893c710 to
8f5a11e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove :cuda_runtime and :rocm_runtime targets
GetRuntimeVersionandGetFuncBySymbolfunctions get moved into the executors - the only place where they are needed.cuda::ToStatuswhich can convert a CUDA runtime error (cudaError_t) into anabsl::Status.RocmKernelandCudaKerneltests which were usingGetFuncBySymboldirectly. Now they rely onLoadKernelfrom the executors.