Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Use HloPredicateIs(Not)Op in all_reduce_blueconnect.cc #19597

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[Cleanup] Use HloPredicateIs(Not)Op in all_reduce_blueconnect.cc #19597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Cleanup] Use HloPredicateIs(Not)Op in all_reduce_blueconnect.cc 
PiperOrigin-RevId: 699048665
  • Loading branch information
@frgossen @Google-ML-Automation
frgossen authored and Google-ML-Automation committed Nov 22, 2024
commit f708b19ac0167282d68c5689f24c0a1713c33cfd
2 changes: 1 addition & 1 deletion xla/service/gpu/transforms/all_reduce_blueconnect.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ absl::StatusOr<bool> AllReduceBlueConnect::Run(
for (HloComputation* computation :
module->MakeNonfusionComputations(execution_threads)) {
for (HloInstruction* instruction : computation->instructions()) {
if (instruction->opcode() == HloOpcode::kAllReduce) {
if (HloPredicateIsOp<HloOpcode::kAllReduce>(instruction)) {
all_reduces.push_back(Cast<HloAllReduceInstruction>(instruction));
}
}
Expand Down
Loading