Bump C64 Log tolerance in exhaustive_unary_complex_test #19782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9efb05 to
b8d5abf
Compare
Upcoming LLVM integration is changing host (CPU) copmuted expectations that is changing the absolute error of a few log cases in a very marginal way where the error is larger than F32 epsilon. I think there could be a tighter bound here, but 2 * eps is still not very large. PiperOrigin-RevId: 699995344
b8d5abf to
bb7f594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump C64 Log tolerance in exhaustive_unary_complex_test
Upcoming LLVM integration is changing host (CPU) copmuted expectations that is changing the absolute error of a few log cases in a very marginal way where the error is larger than F32 epsilon. I think there could be a tighter bound here, but 2 * eps is still not very large.