Fix PropagateShardingAlongDimsAndReplicateOthers and expose it as a public util function.
#19825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ec3213f to
fdaeee5
Compare
… public util function.
The original description is correct, while the implementation is wrong. Given the following input
```
source_sharding = {devices=[2,3,5,7,11]<=[2310]}
source_dims = [2, 4, 1]
target_dims = [2, 1, 3]
target_shape_rank = 5
```
The result shoule be `{devices=[1,11,5,3,1,14]<=[2,3,5,7,11]T(4,2,1,0,3) last_tile_dim_replicate}`.
PiperOrigin-RevId: 700267707
fdaeee5 to
626f1d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
PropagateShardingAlongDimsAndReplicateOthersand expose it as a public util function.The original description is correct, while the implementation is wrong. Given the following input
The result shoule be
{devices=[1,11,5,3,1,14]<=[2,3,5,7,11]T(4,2,1,0,3) last_tile_dim_replicate}.