Update partitioning method for gather/scatter along implicit batch dimensions. #20097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
364ad08 to
c20e99a
Compare
…mensions. We first use `GatherScatterOperandsShardedAcrossParallelDims` to obtain the shardings for operands and indices. We can use the new indices sharding to infer the output sharding (incl. expliict/implicit batch dims and indices pass-through dims). Previously, we only consider expliict batch dims and indices pass-through dims. This cl impacts the implicit batch dims only, without impact on explicit batch dims. PiperOrigin-RevId: 702699803
c20e99a to
dad8d04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update partitioning method for gather/scatter along implicit batch dimensions.
We first use
GatherScatterOperandsShardedAcrossParallelDimsto obtain the shardings for operands and indices. We can use the new indices sharding to infer the output sharding (incl. expliict/implicit batch dims and indices pass-through dims). Previously, we only consider expliict batch dims and indices pass-through dims.This cl impacts the implicit batch dims only, without impact on explicit batch dims.