PR #19913: [ROCm] Do not use fast approximation for exp and log #20187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #19913: [ROCm] Do not use fast approximation for exp and log
Imported from GitHub PR #19913
Error started occurring from this commit for exp 6e9eefe (originally introduced here 9b19353#diff-61ab646c9c3b8b0fc5ed1e9a62f535e9df5843adddd071250343f3bec48eacb6) and from this one 53d5338 for log.
Trying to compile following MLIR code:
would result in:
Copybara import of the project:
--
616c10b by Milica Makevic [email protected]:
Do not use fast approximation for exp and log for ROCm
--
3fa4914 by Milica Makevic [email protected]:
Add unit test for log and exp lowering on ROCm
Merging this change closes #19913
FUTURE_COPYBARA_INTEGRATE_REVIEW=#19913 from ROCm:fix_exp_log_lowering 3fa4914