Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ErrorSpec. #20400

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Remove unused ErrorSpec. #20400

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unused ErrorSpec. 
`//xla/tests:collective_ops_test_cpu` fails to build on tensorflow/xla/linux/cpu/build_cpu.

```
xla/tests/collective_ops_test.cc:1438:19: error: unused variable 'es' [-Werror,-Wunused-variable]
 1438 |   const ErrorSpec es{1e-5, 1e-5};
      |                   ^~
xla/tests/collective_ops_test.cc:1489:19: error: unused variable 'es' [-Werror,-Wunused-variable]
 1489 |   const ErrorSpec es{1e-5, 1e-5};
      |                   ^~
2 errors generated.
```

PiperOrigin-RevId: 704893145
  • Loading branch information
@nvgrw @Google-ML-Automation
nvgrw authored and Google-ML-Automation committed Dec 11, 2024
commit c3d8ca026adade5534631d89456a6e681d7bed63
2 changes: 0 additions & 2 deletions xla/tests/collective_ops_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1435,7 +1435,6 @@ XLA_TEST_F(CollectiveOpsTest, DISABLED_ON_CPU(ReduceScatterReassociate)) {
kNumReplicas,
/*use_threads=*/true, /*run_hlo_passes=*/true));

const ErrorSpec es{1e-5, 1e-5};
LiteralTestUtil::ExpectR1Equal<uint32_t>({26, 30, 34, 38}, results[0]);
LiteralTestUtil::ExpectR1Equal<uint32_t>({42, 46, 50, 54}, results[1]);
}
Expand Down Expand Up @@ -1486,7 +1485,6 @@ XLA_TEST_F(CollectiveOpsTest,
kNumReplicas,
/*use_threads=*/true, /*run_hlo_passes=*/true));

const ErrorSpec es{1e-5, 1e-5};
LiteralTestUtil::ExpectR1Equal<uint32_t>({26, 30, 34, 38}, results[0]);
LiteralTestUtil::ExpectR1Equal<uint32_t>({42, 46, 50, 54}, results[1]);
}
Expand Down
Loading