Split broker.image into separate repository and tag fields#243
Open
sbs-dev1 wants to merge 4 commits intopact-foundation:masterfrom
Open
Split broker.image into separate repository and tag fields#243sbs-dev1 wants to merge 4 commits intopact-foundation:masterfrom
sbs-dev1 wants to merge 4 commits intopact-foundation:masterfrom
Conversation
9760549 to
7b5da74
Compare
7b5da74 to
94a1cc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
broker.imagefrom a single string intobroker.image.repositoryandbroker.image.tagbroker.imagehelper in_helpers.tplto support both formats (backward compatible)Motivation
The current single-string format makes it difficult to override just the registry or just the tag independently. Separate fields are needed for:
repository/tagfields.This is the standard pattern used by Bitnami, Prometheus community, Grafana, Argo, and most major Helm chart publishers.
Changes
values.yaml:templates/_helpers.tpl(backward compatible — accepts both formats):No other templates need changes since they all use
{{ template "broker.image" . }}.Backward Compatibility
The template helper detects whether
broker.imageis a string (old format) or an object (new format), so existing deployments using--set broker.image=registry/image:tagcontinue to work without changes.Validation
All validation steps from the contributing guidelines were executed successfully:
helm template— renders correctly with new format:ghcr.io/pact-foundation/pact-broker:2.137.0-pactbroker2.118.0helm template --set broker.image=custom:tag— backward compat confirmed:custom:taghelm lint— passed (1 chart linted, 0 failed)ct lint— passed against both CI value files (default-values.yamlandexternal-database-with-secret-values.yaml)