Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard timestamp format in single CSV column #68

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

balsama
Copy link
Contributor

@balsama balsama commented Feb 25, 2021

Currently, the date and time of each CSV entry is split into several columns. Specifically:

| YYYYMMDD | HH | MM | {other columns} |

This PR changes the format to a standard timestamp (including seconds) in a single column:

| YYYY-MM-DD HH:MM:SS | {other columns} |

@pageauc
Copy link
Owner

pageauc commented Feb 26, 2021

There is some cleanup required for comments in log_to_csv function. Let me know if you want to do this or me. Also the sql DB still has date, hrs, min as separate fields and remain unchanged. I find the sql db is better to query and manipulate data than managing using the csv file data (My preference)..
Let me know about updating code comments in the log_to_csv function.
Thanks Claude ...

@pageauc pageauc merged commit 66bc49a into pageauc:master Feb 26, 2021
@balsama
Copy link
Contributor Author

balsama commented Feb 26, 2021

I think I found the comment you were referring to (line 913).

I also updated the DB schema in the same way as well as the data inserted..

I should note, I understand you might have very good reason for wanting the hours/minutes in separate columns. I'm not sure if this is desired or not 😅

@balsama
Copy link
Contributor Author

balsama commented Feb 26, 2021

Oh wow! Merged! Thanks!

You might be interested in this article: https://mass.streetsblog.org/2021/02/26/how-to-build-a-homemade-speed-camera/

Thanks for this awesome work.

@pageauc
Copy link
Owner

pageauc commented Feb 26, 2021

I will do some testing but may have to start a fresh database to accommodate the new schema.
Read your article and will add link on github.
No winter in Texas this year. This is our first winter in Canada in 12 years. Hoping to head south to Texas in the Fall. In the mean time locked down at home. I can monitor our place in Texas using a rpi in a security camera case using my pi-timolo program that puts motion tracking and/or timelapse images/video up on my google drive. Also have a humidity and temperature RPI in our mobile home in Texas that updates a Personal Weather station on the Weather underground. https://www.wunderground.com/dashboard/pws/KTXDONNA3/graph/2021-02-24/2021-02-24/weekly

Regards Claude ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants