Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker compose version #79

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Conversation

RandallKent
Copy link
Contributor

Addresses issues with older versions not handling the volumes properly.

@pageauc pageauc merged commit bda3429 into pageauc:master Mar 6, 2021
@RandallKent RandallKent deleted the docker branch March 7, 2021 22:54
@ianmaciel
Copy link
Contributor

I just noticed this PR. Unfortunately it is too late, but we already had a Docker: https://github.com/pageauc/speed-camera/blob/master/.devcontainer/Dockerfile

We could merge these two Dockerfiles into a single one to avoid code duplication.

@RandallKent
Copy link
Contributor Author

@ianmaciel - Always down to avoid duplication/confusion.

The PR I created introducing Docker was intended to allow folks to get up and running in a 'production environment quickly.

The Dockerfile you reference appears to be geared more toward development in VSCode. If we do standardize/streamline, I do think there would be a bit of work to ensure each use case is considered.

I opened a new issue to track this arc of work :)

@ianmaciel
Copy link
Contributor

ianmaciel commented May 7, 2021

Usually it make sense to have two different images: for development and production. So my comment above might be mistaken.

Anyway, it is easy to setup on devcontainer an external Dockerfile.
I am just not sure if the difference between both and if how can this cause any issue...

@ianmaciel
Copy link
Contributor

I'll move this text to the new issue, so we can track better.

@ianmaciel ianmaciel mentioned this pull request May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants