Skip to content

fix: transformed asset types is ignored #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosefBredereck merged 6 commits into from
Feb 7, 2022
Merged

fix: transformed asset types is ignored #1426

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c1cb97e
fix: transformedAssetTypes is ignored #1339
mfranzke Feb 5, 2022
d9179b2
chore: we could still use const here
mfranzke Feb 5, 2022
61465b2
chore: reduced unnecessary slash in the URL
mfranzke Feb 5, 2022
2d9df6c
refactor: simplified regex
mfranzke Feb 5, 2022
8fa644f
refactor: simplified regex
mfranzke Feb 6, 2022
e6a1c69
refactor: corrected the regex
mfranzke Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: simplified regex
  • Loading branch information
@mfranzke
mfranzke committed Feb 5, 2022
commit 2d9df6ce7961921659f7316e8d8caaee864b5193
8 changes: 4 additions & 4 deletions packages/core/src/lib/copier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@ const copier = () => {
debug: patternlab.config.logLevel === 'debug',
};

// Adding assets to filter for in case of transformedAssetTypes defined; adapted regex from packages/core/src/lib/watchAssets.js#L45
// Adding assets to filter for in case of transformedAssetTypes defined; adapted regex from https://stackoverflow.com/a/18086622
if (patternlab.config.transformedAssetTypes) {
copyOptions.filter = new RegExp(
`^.*\\.(?!${patternlab.config.transformedAssetTypes.join(
'$|'
)}$)[^.]+$`,
`^(.*\.(?!(${patternlab.config.transformedAssetTypes.join(
'|'
)})$))?[^.]*$`,
'i'
);
}
Expand Down