Merge pull request satijalab#587 from satijalab/fix/heatmap

Remove random characters from heatmap legend
pchatterjee7 · Jul 30, 2021 · 420bf90 · 420bf90
2 parents 421f472 + 56e3bf4
commit 420bf90
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: Seurat
-Version: 4.0.3.9011
-Date: 2021-07-16
+Version: 4.0.3.9012
+Date: 2021-07-30
 Title: Tools for Single Cell Genomics
 Description: A toolkit for quality control, analysis, and exploration of single cell RNA sequencing data. 'Seurat' aims to enable users to identify and interpret sources of heterogeneity from single cell transcriptomic measurements, and to integrate diverse types of single cell data. See Satija R, Farrell J, Gennert D, et al (2015) <doi:10.1038/nbt.3192>, Macosko E, Basu A, Satija R, et al (2015) <doi:10.1016/j.cell.2015.05.002>, Stuart T, Butler A, et al (2019) <doi:10.1016/j.cell.2019.05.031>, and Hao, Hao, et al (2020) <doi:10.1101/2020.10.12.335331> for more details.
 Authors@R: c(

diff --git a/NAMESPACE b/NAMESPACE
@@ -503,6 +503,7 @@ importFrom(ggplot2,position_jitterdodge)
 importFrom(ggplot2,scale_alpha)
 importFrom(ggplot2,scale_alpha_ordinal)
 importFrom(ggplot2,scale_color_brewer)
+importFrom(ggplot2,scale_color_discrete)
 importFrom(ggplot2,scale_color_distiller)
 importFrom(ggplot2,scale_color_gradient)
 importFrom(ggplot2,scale_color_gradientn)

diff --git a/NEWS.md b/NEWS.md
@@ -13,6 +13,7 @@
 - Bug fix for reading from absolute paths in ReadMtx ([#4723](https://github.com/satijalab/seurat/issues/4723)) 
 - Bug fix in SingleCellExperiment conversion ([#4633](https://github.com/satijalab/seurat/issues/4633))
 - Bug fix in `FindVariableFeatures()` when using `selection.method = "mvp"` and `binning.method = "equal_frequency"` ([#4712](https://github.com/satijalab/seurat/issues/4712))
+- Bug fix in `DoHeatmap()` to remove random characters from plot legend([#4660](https://github.com/satijalab/seurat/issues/4660))
 - Fix cell renaming in `RunCCA()`
 
 ## Seurat 4.0.3 (2020-06-10)`

diff --git a/R/visualization.R b/R/visualization.R
@@ -204,7 +204,7 @@ DimHeatmap <- function(
 #'
 #' @importFrom stats median
 #' @importFrom scales hue_pal
-#' @importFrom ggplot2 annotation_raster coord_cartesian scale_color_manual
+#' @importFrom ggplot2 annotation_raster coord_cartesian scale_color_discrete
 #' ggplot_build aes_string geom_text
 #' @importFrom patchwork wrap_plots
 #' @export
@@ -364,7 +364,7 @@ DoHeatmap <- function(
           ymax = y.max
         ) +
         coord_cartesian(ylim = c(0, y.max), clip = 'off') +
-        scale_color_manual(values = cols)
+        scale_color_discrete(name = "Identity", na.translate = FALSE)
       if (label) {
         x.max <- max(pbuild$layout$panel_params[[1]]$x.range)
         # Attempt to pull xdivs from x.major in ggplot2 < 3.3.0; if NULL, pull from the >= 3.3.0 slot