Add style guideline regarding conditional conjunction formatting#33
Closed
tiffany-taylor wants to merge 1 commit intophp:masterfrom
Closed
Add style guideline regarding conditional conjunction formatting#33tiffany-taylor wants to merge 1 commit intophp:masterfrom
tiffany-taylor wants to merge 1 commit intophp:masterfrom
Conversation
…e formatted in the manual
jimwins
added a commit
to jimwins/doc-base
that referenced
this pull request
Oct 22, 2024
Member
|
Thanks, recreated this against doc-base where the style guide lives now. |
jimwins
added a commit
to php/doc-base
that referenced
this pull request
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Statements which contain a conditional conjunction should be condition first, clause second. There are places in the manual which are formatted the opposite, which can cause confusion for some readers. There are occasionally PRs to doc-en to improve the wording on these statements, but there isn't a formal guideline on how these statements should be formatted. This PR intends to change that.
See php/doc-en#1565