group-domains: fix uncaught TypeError due to invalid URLs

[XhmikosR]

The error happens because the URL constructor throws an error if the url is not valid.

Uncaught TypeError: URL constructor: foo is not a valid URL.

Non-whitespace diff: https://github.com/pi-hole/web/pull/3383/files?w=1

---

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

1. Base your code and PRs against the repositories developmental branch.
2. Sign Off all commits as we enforce the DCO for all contributions
3. Sign all your commits as they must have verified signatures
4. File a pull request for any change that requires changes to our documentation at our documentation repo

---

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code and I have tested my changes.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)
6. I have checked that another pull request for this purpose does not exist.
7. I have considered, and confirmed that this submission will be valuable to others.
8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
9. I give this submission freely, and claim no ownership to its content.

---

• I have read the above and my PR is ready for review. Check this box to confirm

[PromoFaux]

"fix uncaught TypeError "

By chucking it inside an empty try/catch - is this not just supressing it, rather than fixing?

[XhmikosR]

But we need it to be suppressed in this case because we need a valid URL. The input has type URL set, which is probably wrong but that's for another time. Give the patch a go after you try on dev branch with the browser console open and you'll see what I mean :)

…

On Fri, Apr 4, 2025, 20:49 Adam Warner ***@***.***> wrote: "fix uncaught TypeError " By chucking it inside an empty try/catch - is this not just *supressing* it, rather than fixing? — Reply to this email directly, view it on GitHub <#3383 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNLY6VROJGYIKLJJADT2X3A3FAVCNFSM6AAAAAB2NZITJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZZGQYDMNZWGE> . You are receiving this because you authored the thread.Message ID: ***@***.***> [image: PromoFaux]*PromoFaux* left a comment (pi-hole/web#3383) <#3383 (comment)> "fix uncaught TypeError " By chucking it inside an empty try/catch - is this not just *supressing* it, rather than fixing? — Reply to this email directly, view it on GitHub <#3383 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNLY6VROJGYIKLJJADT2X3A3FAVCNFSM6AAAAAB2NZITJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZZGQYDMNZWGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[PromoFaux]

Right, OK - so supressing this particular error is the correct course of action here, because the error thrown is irrelevant.

What if an error is thrown by one of the other lines within the try/catch block? As it stands, we will lose visibility of that error.

[XhmikosR]

OK I will change the function to ignore only these specific errors later

…

On Fri, Apr 4, 2025, 21:07 Adam Warner ***@***.***> wrote: Right, OK - so supressing this particular error is the correct course of action here, because the error thrown is irrelevant. What if an error is thrown by one of the other lines within the try/catch block? As it stands, we will lose visibility of that error. — Reply to this email directly, view it on GitHub <#3383 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNKTJWNLNFFOY66JTXT2X3C6HAVCNFSM6AAAAAB2NZITJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZZGQZTSMZSHA> . You are receiving this because you authored the thread.Message ID: ***@***.***> [image: PromoFaux]*PromoFaux* left a comment (pi-hole/web#3383) <#3383 (comment)> Right, OK - so supressing this particular error is the correct course of action here, because the error thrown is irrelevant. What if an error is thrown by one of the other lines within the try/catch block? As it stands, we will lose visibility of that error. — Reply to this email directly, view it on GitHub <#3383 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNKTJWNLNFFOY66JTXT2X3C6HAVCNFSM6AAAAAB2NZITJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONZZGQZTSMZSHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[PromoFaux]

hmmm, still throwing:

[XhmikosR]

Chrome throws a different error. Try the latest patch please.

[PromoFaux]

Cool, working as expected now