Make use of the new format_path function to add the current page in body#3390
Merged
DL6ER merged 1 commit intopi-hole:developmentfrom May 19, 2025
XhmikosR:xmr/format_path
Merged
Make use of the new format_path function to add the current page in body#3390DL6ER merged 1 commit intopi-hole:developmentfrom XhmikosR:xmr/format_path
DL6ER merged 1 commit intopi-hole:developmentfrom
XhmikosR:xmr/format_path
Conversation
This will allow us to target specific pages more easily Signed-off-by: XhmikosR <xhmikosr@gmail.com>
yubiuser
reviewed
May 4, 2025
Contributor
Author
|
It will be used later, not now. |
Contributor
Author
|
@DL6ER can we please land this? Currently we do all kinds of hacks when it'll be a simple query to identify which page we are on. |
DL6ER
approved these changes
May 19, 2025
Member
I take your word for it. Otherwise, we can revert it in case we find a better solution in the future. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow us to target specific pages more easily
See pi-hole/FTL#2370
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase)