Skip to content

Make use of the new format_path function to add the current page in body#3390

Merged
DL6ER merged 1 commit intopi-hole:developmentfrom
XhmikosR:xmr/format_path
May 19, 2025
Merged

Make use of the new format_path function to add the current page in body#3390
DL6ER merged 1 commit intopi-hole:developmentfrom
XhmikosR:xmr/format_path

Conversation

@XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Apr 8, 2025

This will allow us to target specific pages more easily

See pi-hole/FTL#2370

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

This will allow us to target specific pages more easily

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should have at least one place where we use the new information. Otherwise it does not make sense to add it now.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented May 4, 2025

It will be used later, not now.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented May 9, 2025

@DL6ER can we please land this? Currently we do all kinds of hacks when it'll be a simple query to identify which page we are on.

@PromoFaux PromoFaux requested a review from DL6ER May 19, 2025 16:23
@DL6ER DL6ER merged commit 064154f into pi-hole:development May 19, 2025
8 checks passed
@DL6ER
Copy link
Member

DL6ER commented May 19, 2025

It will be used later, not now.

I take your word for it. Otherwise, we can revert it in case we find a better solution in the future.

@PromoFaux PromoFaux mentioned this pull request May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants