Show loading overlay when adding/removing CNAME records as it requires a FTL restart#3742
Open
yubiuser wants to merge 1 commit intodevelopmentfrom
Open
Show loading overlay when adding/removing CNAME records as it requires a FTL restart#3742yubiuser wants to merge 1 commit intodevelopmentfrom
yubiuser wants to merge 1 commit intodevelopmentfrom
Conversation
…s a FTL restart Signed-off-by: yubiuser <github@yubiuser.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR aim to accomplish?:
When users use the 'Save & Apply' button on the settings page, an loading overlay is shown which stays until FTL is available again in case a restart is required.
Currently, no overlay was shown when a CNAME was added/removed, but this required a FTL restart as well. This should be signaled to the users.
How does this PR accomplish the above?:
Re-use the
utils.loadingOverlayfunctionBy submitting this pull request, I confirm the following:
git rebase)