Skip to content

add TupleOf type#162

Open
DetachHead wants to merge 5 commits intopiotrwitek:masterfrom
DetachHead:master
Open

add TupleOf type#162
DetachHead wants to merge 5 commits intopiotrwitek:masterfrom
DetachHead:master

Conversation

@DetachHead
Copy link
Copy Markdown

@DetachHead DetachHead commented Jan 14, 2021

Description

added TupleOf type using logarithmic method

had to update TS to 4.1.x as it uses recursive conditional types

Related issues:

Checklist

  • I have read CONTRIBUTING.md
  • I have linked all related issues above
  • I have rebased my branch

For bugfixes:

  • I have added at least one unit test to confirm the bug have been fixed
  • I have checked and updated TOC and API Docs when necessary

For new features:

  • I have added entry in TOC and API Docs
  • I have added a short example in API Docs to demonstrate new usage
  • I have added type unit tests with dts-jest

@DetachHead DetachHead marked this pull request as ready for review January 14, 2021 15:29
@DetachHead
Copy link
Copy Markdown
Author

i think the failing tests are caused by changes to type alias resolution in newer typescript versions. i don't think testing types that way is very reliable since there are more changes like that coming in 4.2.

is there a way to structurally test types? none of the libraries i've tried seem to be able to do it properly, which is odd considering typescript is structurally typed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add TupleOf type

1 participant