Skip to content

Commit

Permalink
Un-deprecate custom namespace jobs (prometheus-community#1142)
Browse files Browse the repository at this point in the history
  • Loading branch information
cristiangreco authored Sep 11, 2023
1 parent 36e4d8d commit d9076c8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
4 changes: 1 addition & 3 deletions docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ discovery: <discovery_jobs_list_config>
static:
[ - <static_job_config> ... ]

# Configurations for jobs of type "custom namespace" (deprecated)
# Configurations for jobs of type "custom namespace"
customNamespace:
[ - <custom_namespace_job_config> ... ]
```
Expand Down Expand Up @@ -215,8 +215,6 @@ static:

The `custom_namespace_job_config` block configures jobs of type "custom namespace".

**These type of configs are [deprecated](https://github.com/nerdswords/yet-another-cloudwatch-exporter/pull/888) since [v0.51.0](https://github.com/nerdswords/yet-another-cloudwatch-exporter/blob/v0.51.0/CHANGELOG.md#v0510). Please use [static_job_config](#static_job_config) from now on.**

```yaml
# Name of the job (required)
name: <string>
Expand Down
2 changes: 0 additions & 2 deletions pkg/job/scrape.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,6 @@ func ScrapeAwsData(
}

for _, customNamespaceJob := range cfg.CustomNamespace {
logger.Warn("Jobs of type 'customNamespace' are deprecated and will be removed soon", "job", customNamespaceJob.Name)

for _, role := range customNamespaceJob.Roles {
for _, region := range customNamespaceJob.Regions {
wg.Add(1)
Expand Down

0 comments on commit d9076c8

Please sign in to comment.