Merged
Conversation
…ved in Bootstrap upstream.
… use css variables
…s is solved in Bootstrap upstream." This reverts commit 6bc653a. This fix isn't needed anymore after applying the change from the previous commit which gets rid of the Bootstrap SCSS includes.
8557d14 to
2ca17d2
Compare
petschki
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Begin work on SASS 1.79 compatibility.
Ref:
twbs/bootstrap#40849
twbs/bootstrap#40865
twbs/bootstrap#40864
IIRC (worked on that some days ago) this is not really silencing the deprecation warnings from SASS.
Probably pinning SASS to something before 1.79 is better (
resolveDependencies).