feat(project) list/add/edit/rm project variables#35
Open
sleclercq wants to merge 2 commits intoplouc:masterfrom
Open
feat(project) list/add/edit/rm project variables#35sleclercq wants to merge 2 commits intoplouc:masterfrom
sleclercq wants to merge 2 commits intoplouc:masterfrom
Conversation
7d614d1 to
90d4608
Compare
projects_test.go
Outdated
|
|
||
| _, err := gitlab.ProjectVariable("1", "Somekey") | ||
|
|
||
| assert.Equal(t, err, nil) |
Contributor
There was a problem hiding this comment.
You should use assert.NoError ;)
You should also test the value returned by the function
90d4608 to
8d80c87
Compare
Contributor
Author
|
Done ! Thanks for the tip ! I created a separate commit to use assert.NoError on the whole project, if you prefer me to squash it let me know. |
8d80c87 to
a85a772
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.