Skip to content

[java] Improve UnitTestShouldUse{After,Before}Annotation rules to support JUnit5 and TestNG#5245

Merged
adangel merged 4 commits intopmd:mainfrom
adangel:java-unit-test-rules
Oct 24, 2024
Merged

[java] Improve UnitTestShouldUse{After,Before}Annotation rules to support JUnit5 and TestNG#5245
adangel merged 4 commits intopmd:mainfrom
adangel:java-unit-test-rules

Conversation

@adangel
Copy link
Copy Markdown
Member

@adangel adangel commented Oct 3, 2024

Describe the PR

This is a follow up on #4965 .

Related issues

  • none

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.7.0 milestone Oct 3, 2024
@ghost
Copy link
Copy Markdown

ghost commented Oct 3, 2024

1 Message
📖 Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 12071 new violations, 0 new errors and 0 new configuration errors,
removes 12071 violations, 2 errors and 7 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 12071 new violations, 0 new errors and 0 new configuration errors,
removes 12071 violations, 2 errors and 7 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel force-pushed the java-unit-test-rules branch from db03411 to 9337e5a Compare October 3, 2024 18:55
@adangel adangel marked this pull request as ready for review October 3, 2024 20:42
@adangel adangel added the an:enhancement An improvement on existing features / rules label Oct 18, 2024
@adangel adangel merged commit 40ed459 into pmd:main Oct 24, 2024
@adangel adangel deleted the java-unit-test-rules branch October 24, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

an:enhancement An improvement on existing features / rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant