Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for pytorch-triton #142

Merged
merged 1 commit into from
Sep 1, 2023
Merged

add support for pytorch-triton #142

merged 1 commit into from
Sep 1, 2023

Conversation

pmeier
Copy link
Owner

@pmeier pmeier commented Sep 1, 2023

pytorch_triton sometimes has a commit hash attached to it, e.g.

pytorch_triton-2.1.0+e6216047b8-cp310-cp310-linux_x86_64.whl

It is attached as local specifier (the part after the +), which for now was reserved for the computation backend, e.g. +cpu.

Our logic did not account for local specifiers that aren't computation backends, which in turn caused pytorch-triton to be deselected. This ultimately lead to pytorch/vision#7923 (comment).

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #142 (180a5eb) into main (d914a8e) will decrease coverage by 1.1%.
The diff coverage is 14.2%.

@@           Coverage Diff           @@
##            main    #142     +/-   ##
=======================================
- Coverage   80.0%   78.9%   -1.1%     
=======================================
  Files          6       6             
  Lines        380     385      +5     
=======================================
  Hits         304     304             
- Misses        76      81      +5     
Flag Coverage Δ
unit 78.9% <14.2%> (-1.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
light_the_torch/_patch.py 68.1% <14.2%> (-2.0%) ⬇️

@pmeier pmeier merged commit ff84146 into main Sep 1, 2023
80 of 82 checks passed
@pmeier pmeier deleted the triton branch September 1, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant