-
-
Notifications
You must be signed in to change notification settings - Fork 45
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* fix build errors * fix build errors * docs: wip - improve doc structure * update tsconfig * docs: add CONTRIBUTING.md * use rome instead of eslint * update yarn lock
- Loading branch information
1 parent
ca8b7b8
commit e021cc0
Showing
55 changed files
with
6,408 additions
and
7,162 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
# Contributing to nodejs-polars | ||
|
||
First of all, thank you for considering contributing to nodejs-polars! | ||
|
||
The following is a set of guidelines for contributing to nodejs-polars. These are just guidelines, not rules, use your best judgment and feel free to propose changes to this document in a pull request. | ||
|
||
## How Can I Contribute? | ||
|
||
### Reporting Bugs | ||
|
||
- **Ensure the bug was not already reported** by searching on GitHub under [Issues](https://github.com/pola-rs/nodejs-polars/issues). | ||
|
||
- If you're unable to find an open issue addressing the problem, open a new one. Be sure to include a **title and clear description**, as much relevant information as possible, and a **code sample** or an **executable test case** demonstrating the expected behavior that is not occurring. | ||
|
||
- If possible, use the relevant bug report templates to create the issue. | ||
|
||
### Suggesting Enhancements | ||
|
||
- Open a new GitHub issue in the [Issues](https://github.com/pola-rs/nodejs-polars/issues) with a **clear title** and **description**. | ||
|
||
- If possible, use the relevant enhancement request templates to create the issue. | ||
|
||
|
||
### Pull Requests | ||
|
||
- Fill in the required template | ||
- Use a descriptive title. *(This will end up in the changelog)* | ||
- In the pull request description, link to the issue you were working on. | ||
- Add any relevant information to the description that you think may help the maintainers review your code. | ||
- Make sure your branch is [rebased](https://docs.github.com/en/get-started/using-git/about-git-rebase) against the latest version of the `main` branch. | ||
- Make sure all GitHub Actions checks pass. | ||
|
||
|
||
|
||
## Development | ||
### Vscode | ||
If using VScode, it is recommended to install the following extensions | ||
- rust-analyzer | ||
- rome | ||
--- | ||
|
||
- Fork the repository, then clone it from your fork | ||
``` | ||
git clone https://github.com/<your-github-username>/nodejs-polars.git | ||
``` | ||
|
||
- Install dependencies | ||
``` | ||
yarn install | ||
``` | ||
|
||
- Build the binary | ||
``` | ||
yarn build:debug | ||
``` | ||
|
||
- Run the tests | ||
``` | ||
yarn jest | ||
``` | ||
|
||
- Make your changes | ||
- Test your changes | ||
- | ||
You can run the `precommit` command to make sure all of your tests pass & code is formatted correctly. | ||
``` | ||
yarn precommit | ||
``` | ||
|
||
- Update the documentation if necessary | ||
- Create a new pull request |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,16 @@ | ||
import pl from "@polars"; | ||
|
||
|
||
describe("complex types", () => { | ||
|
||
test.skip("nested arrays round trip", () => { | ||
const arr = [[["foo"]], [], null]; | ||
const s = pl.Series("", arr); | ||
const actual = s.toArray(); | ||
expect(actual).toEqual(arr); | ||
}); | ||
test.skip("struct arrays round trip", () => { | ||
const arr = [{foo: "a", bar: 1}, null, null]; | ||
const arr = [{ foo: "a", bar: 1 }, null, null]; | ||
const s = pl.Series("", arr); | ||
const actual = s.toArray(); | ||
expect(actual).toEqual(arr); | ||
}); | ||
|
||
}); |
Oops, something went wrong.