Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix panic with empty delta scan, or empty parquet scan with a provided schema #19884

Merged
merged 12 commits into from
Nov 21, 2024
Merged

fix: Fix panic with empty delta scan, or empty parquet scan with a provided schema #19884

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4b330ee
c
nameexhaustion Nov 20, 2024
64ba11f
c
nameexhaustion Nov 20, 2024
82c9f57
c
nameexhaustion Nov 20, 2024
a869d72
c
nameexhaustion Nov 20, 2024
24d1c78
c
nameexhaustion Nov 20, 2024
7a1ac04
c
nameexhaustion Nov 20, 2024
f51f2c3
c
nameexhaustion Nov 20, 2024
1f129c6
c
nameexhaustion Nov 20, 2024
5f63e49
c
nameexhaustion Nov 20, 2024
c4f20a5
c
nameexhaustion Nov 20, 2024
a31039f
fix empty delta test
nameexhaustion Nov 21, 2024
a4598a3
fix pydantic
nameexhaustion Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
c
  • Loading branch information
@nameexhaustion
nameexhaustion committed Nov 21, 2024
commit 82c9f571d94684dcf063c5621bfb962e9547589f
5 changes: 3 additions & 2 deletions crates/polars-plan/src/plans/conversion/dsl_to_ir.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,11 +235,12 @@ pub fn to_alp_impl(lp: DslPlan, ctxt: &mut DslConversionContext) -> PolarsResult
};

if file_options.hive_options.enabled.is_none() {
// TODO: Auto-enable this based on whether we received a hive schema.
file_options.hive_options.enabled = Some(false);
}

if file_options.hive_options.enabled.unwrap() == false
&& file_options.hive_options.schema.is_some()
if file_options.hive_options.schema.is_some()
&& !file_options.hive_options.enabled.unwrap()
{
polars_bail!(
ComputeError:
Expand Down