fix: forward on insert.text breaks undo batching#2243
Merged
christianhg merged 2 commits intomainfrom Mar 6, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: cb518a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
283a933 to
472d625
Compare
472d625 to
20622da
Compare
20622da to
cb518a9
Compare
Merged
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a behavior uses
forward(event)oninsert.textwith a second action set, each typed character becomes its own undo step instead of merging with adjacent characters.This breaks the expected undo behavior for any behavior that observes text insertion without modifying it (e.g., a behavior that forwards the text and then checks the block content to update styles).
Root cause
performEventsets a uniqueundoStepIdfor everyinsert.textevent because it's synthetic (not innativeBehaviorEventTypes). Without custom behaviors, the default handler clearsundoStepIdbefore running the operation, so consecutive characters merge via the history plugin's merge heuristic. But when a behaviorforwards the event,defaultBehaviorOverwritten = trueand the clearing never happens. Each character gets a uniqueundoStepId, preventing history merge.Fix
Add a merge heuristic in
undo-step.tsfor the case where consecutive operations have different definedundoStepIds. When both IDs are defined but different, and the operations are consecutiveinsert_textat adjacent offsets on the same path (or consecutiveremove_text), merge them into the same undo step. This matches the existing merge behavior for theundefinedID case.This approach avoids changing
performEventand preserves the existing undo step separation for:insert.block(different op types, notinsert_text)Testing
Two new browser tests verify the fix:
insert.textpreserves undo batchinginsert.textwith side effect preserves undo batching