fix: prevent intermittent image duplication during internal drag-and-drop#2350
Draft
christianhg wants to merge 1 commit intomainfrom
Draft
fix: prevent intermittent image duplication during internal drag-and-drop#2350christianhg wants to merge 1 commit intomainfrom
christianhg wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (d58ddc7) |
|---|---|---|
| Internal (raw) | 779.1 KB | -145 B, -0.0% |
| Internal (gzip) | 145.2 KB | -22 B, -0.0% |
| Bundled (raw) | 1.39 MB | -145 B, -0.0% |
| Bundled (gzip) | 308.1 KB | -22 B, -0.0% |
| Import time | 92ms | -2ms, -2.2% |
@portabletext/editor/behaviors
| Metric | Value | vs main (d58ddc7) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 6ms | -0ms, -5.2% |
@portabletext/editor/plugins
| Metric | Value | vs main (d58ddc7) |
|---|---|---|
| Internal (raw) | 2.5 KB | - |
| Internal (gzip) | 910 B | - |
| Bundled (raw) | 2.3 KB | - |
| Bundled (gzip) | 839 B | - |
| Import time | 11ms | -0ms, -2.8% |
@portabletext/editor/selectors
| Metric | Value | vs main (d58ddc7) |
|---|---|---|
| Internal (raw) | 60.2 KB | - |
| Internal (gzip) | 9.4 KB | - |
| Bundled (raw) | 56.7 KB | - |
| Bundled (gzip) | 8.6 KB | - |
| Import time | 10ms | -0ms, -2.7% |
@portabletext/editor/utils
| Metric | Value | vs main (d58ddc7) |
|---|---|---|
| Internal (raw) | 24.2 KB | - |
| Internal (gzip) | 4.7 KB | - |
| Bundled (raw) | 22.2 KB | - |
| Bundled (gzip) | 4.4 KB | - |
| Import time | 9ms | -0ms, -3.2% |
Details
- Import time regressions over 10% are flagged with
⚠️ - Treemap artifacts are attached to the CI run for detailed size analysis
- Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
🦋 Changeset detectedLatest commit: 05698a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clients report intermittent block duplication when drag-and-dropping images internally.
Root Cause
A race condition between two
dropevent handlers:onDropon the editor element — readsinternalDragfrom the actor context to determinedragOrigin, then sends thedrag.dropbehavior eventdroplistener ondocument— sends{type: 'drop'}to the actor, which transitions the machine fromdragging internally→idleand clearsinternalDragIf the window listener fires before React's
onDropreadsinternalDrag,dragOriginisundefined. This causes the fallbackdrag.dropbehavior to fire (the one for external drops), which deserializes and inserts the block without deleting the original — resulting in duplication.Fix
droplistener{type: 'drop'}fromhandleDropafter the behavior event, ensuringinternalDragis always available when the behavior event is processedThe window-level
dragendlistener is kept — it's needed for drags that end outside the editor (e.g., user drags a block and drops it on the desktop).