fix: assert numeric last segment on insert_node operations#2356
Closed
christianhg wants to merge 1 commit intomainfrom
Closed
fix: assert numeric last segment on insert_node operations#2356christianhg wants to merge 1 commit intomainfrom
christianhg wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (d992e30) |
|---|---|---|
| Internal (raw) | 775.7 KB | +264 B, +0.0% |
| Internal (gzip) | 144.5 KB | +65 B, +0.0% |
| Bundled (raw) | 1.38 MB | +264 B, +0.0% |
| Bundled (gzip) | 307.5 KB | +52 B, +0.0% |
| Import time | 91ms | -3ms, -3.1% |
@portabletext/editor/behaviors
| Metric | Value | vs main (d992e30) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 6ms | -0ms, -3.4% |
@portabletext/editor/plugins
| Metric | Value | vs main (d992e30) |
|---|---|---|
| Internal (raw) | 2.5 KB | - |
| Internal (gzip) | 910 B | - |
| Bundled (raw) | 2.3 KB | - |
| Bundled (gzip) | 839 B | - |
| Import time | 11ms | -0ms, -3.6% |
@portabletext/editor/selectors
| Metric | Value | vs main (d992e30) |
|---|---|---|
| Internal (raw) | 60.2 KB | - |
| Internal (gzip) | 9.4 KB | - |
| Bundled (raw) | 56.7 KB | - |
| Bundled (gzip) | 8.6 KB | - |
| Import time | 10ms | -1ms, -4.9% |
@portabletext/editor/utils
| Metric | Value | vs main (d992e30) |
|---|---|---|
| Internal (raw) | 24.2 KB | - |
| Internal (gzip) | 4.7 KB | - |
| Bundled (raw) | 22.2 KB | - |
| Bundled (gzip) | 4.4 KB | - |
| Import time | 9ms | -0ms, -1.7% |
Details
- Import time regressions over 10% are flagged with
⚠️ - Treemap artifacts are attached to the CI run for detailed size analysis
- Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a runtime assertion in
Transforms.transformthat throws if aninsert_nodeoperation has a non-numeric last path segment.insert_noderequires a numeric index because the node doesn't exist in the array yet — you can't find it by key. Without this assertion, a keyed last segment silently gets coerced, causing corrupted tree state that's hard to trace back to the source.No changeset needed — this is an internal assertion that doesn't change behavior for correct code.