fix: remove internal select and setSelection editor methods#2369
Closed
christianhg wants to merge 2 commits intomainfrom
Closed
fix: remove internal select and setSelection editor methods#2369christianhg wants to merge 2 commits intomainfrom
select and setSelection editor methods#2369christianhg wants to merge 2 commits intomainfrom
Conversation
Remove editor.select and editor.setSelection from the editor interface. All callers now import the core functions directly. The behavior-api plugin that intercepted these calls to send behavior events is deleted since no behavior intercepts the raw select event — the round-trip through the behavior system was a no-op.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
|
⏳ Bundle Stats — Calculating bundle sizes for @portabletext/editor... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
editor.selectandeditor.setSelectionfrom the editor interface. All callers now import the core functions directly fromcore/selectandcore/set-selection.The
behavior-apiplugin that intercepted these calls is deleted. It sent behavior events for every selection change, but no behavior actually intercepts the rawselectevent — the round-trip through the behavior system was a no-op. Selection updates to the editor machine still work becauseupdateSelectionPluginfires on everyonChangeindependently of the behavior-api plugin.Callers that previously went through
editor.select()oreditor.setSelection()(Slate core internals likecollapse,move,delete-text,insert-nodes,insert-text; DOM layer code indom-editor,editable.tsx,android-input-manager; and PTE layer code inEditable.tsxandeditor-machine) now call the core functions directly.