Add support for dir-dependency messages
#383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanZim
requested changes
May 29, 2021
Collaborator
RyanZim
left a comment
There was a problem hiding this comment.
Sorry so long in getting around to reviewing this; time flies.
This needs tests, also one nitpick.
Contributor
Author
|
No problem @RyanZim, thanks for taking a look! I have added some tests now 👍 |
RyanZim
approved these changes
Jun 14, 2021
1st8
added a commit
to 1st8/postcss-cli
that referenced
this pull request
Aug 27, 2021
This extends postcss#383 to pass glob information on to chokidar, with the intention of reducing outputs when unrelated files are modified
This was referenced Aug 27, 2021
RyanZim
pushed a commit
that referenced
this pull request
Sep 23, 2021
This extends #383 to pass glob information on to chokidar, with the intention of reducing outputs when unrelated files are modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
dir-dependencymessages.Directory dependencies are added to the dependency graph in the same way that files are. Chokidar accepts directories and will watch them recursively. Then, when a file changes we determine the "recompile" list by finding the dependants of each of the files ancestor directories.
Any questions or concerns let me know 👍