Skip to content

optimize check_case_conflict.parents #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asottile merged 2 commits into from
Jul 10, 2021
Merged

optimize check_case_conflict.parents #626

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a4333f
optimize check_case_conflict.parents
guykisel Jul 9, 2021
2468167
remove unused os.path
guykisel Jul 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pre_commit_hooks/check_case_conflict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import argparse
import os.path
from typing import Iterable
from typing import Iterator
from typing import Optional
Expand All @@ -15,10 +14,11 @@ def lower_set(iterable: Iterable[str]) -> Set[str]:


def parents(file: str) -> Iterator[str]:
file = os.path.dirname(file)
while file:
yield file
file = os.path.dirname(file)
path_parts = file.split('/')
path_parts.pop()
while path_parts:
yield '/'.join(path_parts)
path_parts.pop()


def directories_for(files: Set[str]) -> Set[str]:
Expand Down