Skip to content

Comments

Fixing Sketches list does not update after renaming a sketch#3927

Open
Jatin24062005 wants to merge 1 commit intoprocessing:developfrom
Jatin24062005:fixing_renaming_live_reload
Open

Fixing Sketches list does not update after renaming a sketch#3927
Jatin24062005 wants to merge 1 commit intoprocessing:developfrom
Jatin24062005:fixing_renaming_live_reload

Conversation

@Jatin24062005
Copy link
Contributor

Issue:

Fixes #3921

Demo:

image

Changes:

the reducer logic for ActionTypes.RENAME_PROJECT. Previously, the implementation attempted to update the state directly, but did not properly handle the projects array inside the state.
Now, the reducer correctly:

  • Iterates over state.projects using map.
  • Matches the project by id from the action.payload.
  • Returns a new project object with the updated name.
  • Preserves all other projects and the rest of the state immutably.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sketches list does not update after renaming a sketch

1 participant