CMake: Stop building tests by default (related to #20539)#24373
Closed
hartwork wants to merge 1 commit intoprotocolbuffers:mainfrom
Closed
CMake: Stop building tests by default (related to #20539)#24373hartwork wants to merge 1 commit intoprotocolbuffers:mainfrom
hartwork wants to merge 1 commit intoprotocolbuffers:mainfrom
Conversation
b696676 to
6be6748
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 12, 2025
#test-continuous Related to #20539, in reaction to #20539 (comment) CC @mkruskal-google Closes #24373 COPYBARA_INTEGRATE_REVIEW=#24373 from hartwork:cmake-stop-building-tests-by-default 6be6748 FUTURE_COPYBARA_INTEGRATE_REVIEW=#24373 from hartwork:cmake-stop-building-tests-by-default 6be6748 PiperOrigin-RevId: 831563407
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
#test-continuous Related to #20539, in reaction to #20539 (comment) CC @mkruskal-google Closes #24373 COPYBARA_INTEGRATE_REVIEW=#24373 from hartwork:cmake-stop-building-tests-by-default 6be6748 FUTURE_COPYBARA_INTEGRATE_REVIEW=#24373 from hartwork:cmake-stop-building-tests-by-default 6be6748 PiperOrigin-RevId: 831563407
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
#test-continuous Related to #20539, in reaction to #20539 (comment) CC @mkruskal-google Closes #24373 COPYBARA_INTEGRATE_REVIEW=#24373 from hartwork:cmake-stop-building-tests-by-default 6be6748 FUTURE_COPYBARA_INTEGRATE_REVIEW=#24373 from hartwork:cmake-stop-building-tests-by-default 6be6748 PiperOrigin-RevId: 831563407
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
#test-continuous Related to #20539, in reaction to #20539 (comment) CC @mkruskal-google Closes #24373 COPYBARA_INTEGRATE_REVIEW=#24373 from hartwork:cmake-stop-building-tests-by-default 6be6748 FUTURE_COPYBARA_INTEGRATE_REVIEW=#24373 from hartwork:cmake-stop-building-tests-by-default 6be6748 PiperOrigin-RevId: 831563407
mkruskal-google
approved these changes
Nov 13, 2025
copybara-service bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
#test-continuous Related to #20539, in reaction to #20539 (comment) CC @mkruskal-google Closes #24373 COPYBARA_INTEGRATE_REVIEW=#24373 from hartwork:cmake-stop-building-tests-by-default 6be6748 FUTURE_COPYBARA_INTEGRATE_REVIEW=#24373 from hartwork:cmake-stop-building-tests-by-default 6be6748 PiperOrigin-RevId: 831563407
Contributor
Author
|
@mkruskal-google thanks for pulling this over the finish line 👍 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #20539, in reaction to #20539 (comment)
CC @mkruskal-google