Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vasilis/drlearner #137

Merged
merged 51 commits into from
Nov 11, 2019
Merged

Vasilis/drlearner #137

merged 51 commits into from
Nov 11, 2019

Conversation

vasilismsr
Copy link
Contributor

No description provided.

@vasilismsr vasilismsr added the enhancement New feature or request label Nov 6, 2019
@vasilismsr vasilismsr requested a review from kbattocchi November 6, 2019 05:00
@vasilismsr vasilismsr assigned vasilismsr and unassigned moprescu and heimengqi Nov 6, 2019
heimengqi
heimengqi reviewed Nov 6, 2019
View reviewed changes
Copy link
Contributor

@heimengqi heimengqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's removed from metalearners? so no need to extend it to support multi treatment anymore?

@vasilismsr
changed tests in dml to adhere to the CATE API. Some calls to effect …
c63d6b3 
…had T0 and T1 as non keyword arguments. They should be. A bug fix in treatment expansion mixin revealed this mistake.
@moprescu
Copy link
Contributor

moprescu commented Nov 6, 2019

@vasilismsr @heimengqi
I think we should extend the drlearner to accept multiple discrete treatment. The extension should be straight forward as it's already done in the ORF.

@vasilismsr
Copy link
Contributor Author

The new implementation already does that.

@vasilismsr
added exhaustive tests for drlearner. Fixed bugs from corner cases
d2494b6
@vasilismsr
bug in docstring regarding how split is called to generate crossfit f…
e75fd48 
…olds
@vasilismsr
changed bootstarp tests to conform with keyword only effect and effec…
fbc3f1d 
…t_interval
@vasilismsr
bootstrap tests, fixing bugs related to positional arguments T0, T1
3397d95
@vasilismsr
linting
b13581e
@vasilismsr
more tests for drlearner and small bugs
e4c355d
@vasilismsr
reverted back to coef_ and intercept_. Fixed docstring. Added exhaust…
8611577 
…ive tests for api of drlearner and linear_drlearner. Fixed small bug in marginal_effect_interval of linearcateestimator.
@vasilismsr
added checks of fitted dims for W and Z during scoring in _OrthoLearn…
0dcea06 
…er. Bug from reverting back to coef_ and intercept_ in StatsModelsInference.
@vasilismsr
testing notebook
7c55fb0
@kbattocchi kbattocchi mentioned this pull request Nov 8, 2019
Open
kbattocchi
kbattocchi requested changes Nov 8, 2019
View reviewed changes
econml/drlearner.py Outdated Show resolved Hide resolved
econml/drlearner.py Outdated Show resolved Hide resolved
econml/drlearner.py Outdated Show resolved Hide resolved
econml/drlearner.py Outdated Show resolved Hide resolved
econml/drlearner.py Outdated Show resolved Hide resolved
econml/drlearner.py Show resolved Hide resolved
econml/drlearner.py Outdated Show resolved Hide resolved
econml/drlearner.py Outdated Show resolved Hide resolved
@vasilismsr vasilismsr merged commit 72a7022 into master Nov 11, 2019
@vasilismsr vasilismsr deleted the vasilis/drlearner branch November 11, 2019 18:29
This was referenced Nov 11, 2019
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimengqi heimengqi heimengqi left review comments

@kbattocchi kbattocchi kbattocchi approved these changes

@moprescu moprescu Awaiting requested review from moprescu

Assignees

@vasilismsr vasilismsr

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vasilismsr @moprescu @kbattocchi @heimengqi