Correct DML shapes for vectors #15

kbattocchi · 2019-03-21T21:52:35Z

This set of changes makes it so that DML can work with vector T or Y, and also makes X optional to comply with the signature.

kbattocchi · 2019-04-05T21:06:19Z

This addresses issues #16 and #17 for DML, but I want to make another pass to make sure that all other estimators also handle these cases.

kbattocchi force-pushed the kebatt/shape branch from 4979219 to 86b57d5 Compare March 22, 2019 20:41

kbattocchi marked this pull request as ready for review April 5, 2019 20:21

kbattocchi requested a review from moprescu April 5, 2019 20:21

kbattocchi force-pushed the kebatt/shape branch from 86b57d5 to 27b6323 Compare April 5, 2019 20:23

kbattocchi added this to the v0.2 milestone Apr 5, 2019

kbattocchi added 2 commits April 8, 2019 10:36

Remove "complex" featurization from DML

85ff184

Correct DML shapes for vectors

9ffb8b4

kbattocchi force-pushed the kebatt/shape branch from 27b6323 to 9ffb8b4 Compare April 8, 2019 14:37

moprescu approved these changes Apr 8, 2019

View reviewed changes

kbattocchi merged commit 5f2b5d6 into master Apr 8, 2019

kbattocchi deleted the kebatt/shape branch April 8, 2019 15:17

Provide feedback