Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vasilis/forest dml docs #197

Merged
merged 102 commits into from
Dec 5, 2019
Merged

Vasilis/forest dml docs #197

merged 102 commits into from
Dec 5, 2019

Conversation

vasilismsr
Copy link
Contributor

Revamped all our user guides.

vasilismsr and others added 30 commits November 18, 2019 18:49
@vasilismsr
added honest forest based dml estimator and also generic nonparametri…
264751e 
…c dml estimator
@vasilismsr
Merge branch 'master' into vasilis/forest_dml
0e16f45
@vasilismsr
linting
b1e0162
@vasilismsr
corrected the use of sample_var in honest forest for construction of CI.
cd60cae
@vasilismsr
added tests of cate API for NonParamDML and ForestDML. Fixed bugs
43ee1ee
@vasilismsr
a perfomrance test for forest dml
4adda21
@vasilismsr
monte carlo script for honest forest coverage
cc96372
@vasilismsr
Update test_dml.py
6692ef4
@vasilismsr
stabiliized randomness in forest dml test
8d24d76
@vasilismsr
removed bootstrap tests when treatment discrete until stratification …
e3e2792 
…in bootstrap is fixed.
@vasilismsr
simplified models in test dml nonparam
20866ad
@vasilismsr
simplified models in test dml nonparam
e0b1e06
@vasilismsr
added also monte carlo tests for LinearDML with statsmodels and coverage
297d318
monte carlo statsmodels bug from older version of linear dml.
d47feac
@vasilismsr
added forest dml in notebook
644ba18
@vasilismsr
dml notebook
37b2304
@vasilismsr
imprvoements on DML notebook
8eae231
@vasilismsr
imprvoements on DML notebook
9603f76
@vasilismsr
imprvoements on DML notebook
141866d
@vasilismsr
Merge branch 'master' into vasilis/forest_dml
5bb9665
@vasilismsr
fixed final bugs from merging with master
54edbab
@vasilismsr
added more tests to increase coverage of all lines of dml.py. Made so…
423b9f5 
…me minor changes to the class hierarchy to remove code duplication.
@vasilismsr
made n_jobs=1 in some tests of ORF to increase coverage of causal_tre…
00c50ce 
…e.py
@vasilismsr
linting errors
30ec543
changes to the monte carlo for statsmodels. Small change to add valid…
dec5aa3 
…ate=True in the FunctionTransformer in dml.yp
@vasilismsr
added Forest DRLearner, that uses an HonestForest for each CATE and o…
7851864 
…ffers non-parametric inference.
@vasilismsr
fixed bug related to when honest=False in subsamplehonestforest
17928d8
@vasilismsr
Merge branch 'vasilis/forest_dml' of github.com-microsoft:Microsoft/E…
fded888 
…conML into vasilis/forest_dml
@vasilismsr
restructured inference classes in a hierarchy so as to save code dupl…
0bc9620 
…ication.
@vasilismsr
added docstrings to inference classes
dd6fede
kbattocchi
kbattocchi requested changes Dec 5, 2019
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. GitHub seems to have trouble making a minimal diff of the sklearn_extensions/ensemble.py file - what is the nature of the changes there?

doc/spec/estimation/dml.rst Outdated Show resolved Hide resolved
doc/spec/estimation/dr.rst Outdated Show resolved Hide resolved
doc/reference.rst Show resolved Hide resolved
vasilismsr
vasilismsr commented Dec 5, 2019
View reviewed changes
Copy link
Contributor Author

@vasilismsr vasilismsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. GitHub seems to have trouble making a minimal diff of the sklearn_extensions/ensemble.py file - what is the nature of the changes there?

Minimal changes. Mostly some backslashes were missing from docstrings

kbattocchi
kbattocchi approved these changes Dec 5, 2019
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vasilismsr vasilismsr merged commit 3c36288 into master Dec 5, 2019
@vasilismsr vasilismsr deleted the vasilis/forest_dml_docs branch December 5, 2019 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

@heimengqi heimengqi Awaiting requested review from heimengqi

@ewdillon ewdillon Awaiting requested review from ewdillon

@moprescu moprescu Awaiting requested review from moprescu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasilismsr @kbattocchi