-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test to run each notebook, reporting all errors #23
Conversation
e2d8f5e
to
e333cfc
Compare
This set of changes does two things:
|
@moprescu How long would you expect the ortho notebook to run? It looks like that's what's causing the build failure... (timeout after 1 hr) |
c515e24
to
d80c995
Compare
@moprescu Even with Vasilis's perf improvements the notebooks still take 45 minutes to run. Any ideas about opportunities for further performance improvement? |
I think we should separate the OJ dataset. That’s the part that takes 45. In particular the final bootstrap. Without the final bootstrap the whole notebook just takes at most 7min. We could also just remove that final bootstrap. |
Maybe we could do a bootstrap example in the synthetic data cells above but not in the OJ |
d80c995
to
f663909
Compare
@vasilismsr It looks like if we just use fewer trees (say n_trees=100 instead of 2000) we can cut the time way down, at the cost of having wider confidence intervals. Then we could add some explanatory text pointing out that for greater fidelity you could use more trees but we used fewer for the sake of running more quickly. Do you see a problem with this? |
that seems a good solution too |
0889197
to
7b3554d
Compare
I've updated the notebook to use only 100 trees for the bootstrap estimation, and now all checks complete within 20 minutes. |
7b3554d
to
fb5e02f
Compare
d402f76
to
776e2c0
Compare
b158e12
to
fb4699e
Compare
fb4699e
to
23886ac
Compare
No description provided.