Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for W in DoublyRobustLearner class. #25

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

moprescu
Copy link
Contributor

@moprescu moprescu commented Apr 4, 2019

In this commit:

  • fit method now accepts W (default=None) in DoublyRobustLearner.
    outcome model and propensity model is fit on X||W.

  • A new test for DoublyRobustLearner with X and W separate.

Resolves: #19

In this commit:

 * fit method now accepts W (default=None) in DoublyRobustLearner.
 outcome model and propensity model is fit on X||W.

 * A new test for DoublyRobustLearner with X and W separate.

Resolves: #19
@moprescu moprescu added the enhancement New feature or request label Apr 4, 2019
@moprescu moprescu added this to the v0.2 milestone Apr 4, 2019
@moprescu moprescu self-assigned this Apr 4, 2019
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@moprescu moprescu merged commit be281d3 into master Apr 5, 2019
@moprescu moprescu deleted the moprescu/metalearners branch April 5, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants