Refactor DML classes to use a more general RLearner base class #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbf793a to
d68733e
Compare
|
I've also made two other changes:
These are visible as separate commits. |
de0ec5b to
cc271d3
Compare
vasilismsr
approved these changes
Apr 10, 2019
cc271d3 to
004f8bf
Compare
004f8bf to
614411f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the DML classes, adding an internal base class that should allow us to generalize to "3ML" a la the Orthogonal Statistical Learning paper by Dylan and Vasilis.