-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add shap value features on each estimator (depends on master branch of shap) #336
Conversation
heimengqi
commented
Dec 8, 2020
- add shap_values method on each of our estimators except for OrthoIV classes, which plan to add after we have a more complete version of subclasses
- Currently this PR depends on the master branch of shap package, not the released version
- Fix the comparison table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, but I added some feedback.
3a54299
to
86a4283
Compare
1afe249
to
d0dcc13
Compare
d0dcc13
to
d6b44ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another general request: I think we should have a Explain Cate with SHAP.ipynb notebook that portrays all the functionality with SHAP. It seems important. But we could also do this post-release and prioritize all the other changes requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All comments have been addressed!